DEPR: DataFrame.swapaxes #51960
DEPR: DataFrame.swapaxes #51960
Conversation
| msg = "'DataFrame.swapaxes' is deprecated" | ||
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| msg = "No axis named 2 for object type DataFrame" | ||
| with pytest.raises(ValueError, match=msg): | ||
| df.swapaxes(2, 5) |
There was a problem hiding this comment.
Not sure if nested blocks of code are better expressed. (pytest may break pre-commit)
| @@ -251,7 +251,6 @@ | |||
| operator.methodcaller("isin", pd.DataFrame({"A": [1]})), | |||
| ), | |||
| ), | |||
| (pd.DataFrame, frame_data, operator.methodcaller("swapaxes", 0, 1)), | |||
There was a problem hiding this comment.
It seems that this file is testing all existing finalize methods, so I removed swapaxes due to its depreciation.
| with tm.assert_produces_warning( | ||
| FutureWarning, match=".swapaxes' is deprecated", check_stacklevel=False | ||
| ): | ||
| assert len(np.array_split(o, 5)) == 5 |
There was a problem hiding this comment.
Why is swapaxes being called here?
There was a problem hiding this comment.
/home/luke/mambaforge/envs/pandas-dev/lib/python3.8/site-packages/numpy/core/fromnumeric.py:57: FutureWarning: 'DataFrame.swapaxes' is deprecated and will be removed in a future version. Please use 'DataFrame.transpose' instead.
return bound(*args, **kwds)
It will raise an warning (maybenp.array_split to np.swapaxes to df.swapaxes, I'm not sure), and let CI "Numpy Dev" failed.
There was a problem hiding this comment.
Will np.array_split cease to work once swapaxes is removed?
There was a problem hiding this comment.
yes. If remove swapaxes, this test will work find, without the depreciation waring.
Co-authored-by: Matthew Roeschke <[email protected]>
|
Thanks @luke396 |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.