Skip to content

TST: adds a test to check signedness preservation after sum #57306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

TST: adds a test to check signedness preservation after sum #57306

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309b6a0
add a test to check signedness preservation after sum
banorton Feb 8, 2024
2581a75
removed test for int8 and added issue number
banorton Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pandas/tests/reductions/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,17 @@ def test_sum_uint64(self):
expected = np.uint64(10000000000000000000)
tm.assert_almost_equal(result, expected)

def test_signedness_preserved_after_sum(self):
s = Series([1, 2, 3, 4])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_signedness_preserved_after_sum(self):
s = Series([1, 2, 3, 4])
def test_signedness_preserved_after_sum(self):
# GH 37491
ser = Series([1, 2, 3, 4])


result1 = s.astype("int8").sum().dtype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to test this one

result2 = s.astype("uint8").sum().dtype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you assert the actual result of s.astype("uint8").sum()?

expected1 = "int64"
expected2 = "uint64"

assert result1 == expected1
assert result2 == expected2


class TestDatetime64SeriesReductions:
# Note: the name TestDatetime64SeriesReductions indicates these tests
Expand Down