TST: adds a test to check signedness preservation after sum #57306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 8, 2024
| def test_signedness_preserved_after_sum(self): | ||
| s = Series([1, 2, 3, 4]) | ||
|
|
||
| result1 = s.astype("int8").sum().dtype |
mroeschke
reviewed
Feb 8, 2024
| s = Series([1, 2, 3, 4]) | ||
|
|
||
| result1 = s.astype("int8").sum().dtype | ||
| result2 = s.astype("uint8").sum().dtype |
There was a problem hiding this comment.
Can you assert the actual result of s.astype("uint8").sum()?
mroeschke
reviewed
Feb 8, 2024
Comment on lines
1262
to
1263
| def test_signedness_preserved_after_sum(self): | ||
| s = Series([1, 2, 3, 4]) |
There was a problem hiding this comment.
Suggested change
| def test_signedness_preserved_after_sum(self): | |
| s = Series([1, 2, 3, 4]) | |
| def test_signedness_preserved_after_sum(self): | |
| # GH 37491 | |
| ser = Series([1, 2, 3, 4]) |
|
I removed the unnecessary test and added the issue number :) |
mroeschke
approved these changes
Feb 8, 2024
|
Thanks @banorton |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…ev#57306) * add a test to check signedness preservation after sum * removed test for int8 and added issue number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to make sure the result of sum does not alter the signedness of the input.