-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Add macOS M1 CI #57163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI: Add macOS M1 CI #57163
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bb27294
CI: Start testing on M1
lithomas1 c5572a8
Merge branch 'main' of github.com:pandas-dev/pandas into add-m1-ci
lithomas1 1890c74
install pytest-localserver from pip
lithomas1 efefbe6
typo
lithomas1 e96a2bf
more CI adjustments and try to fix wheel builders
lithomas1 e9b0d82
more fixes
lithomas1 058f63c
auto workers on windows as well
lithomas1 9b41034
fix wheel builders
lithomas1 59a17de
Update wheels.yml
lithomas1 5ae83e1
bump cibuildwheel
lithomas1 ae97358
bump both
lithomas1 c0ede62
maybe fix windows as well
lithomas1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,7 +94,9 @@ jobs: | |
buildplat: | ||
- [ubuntu-22.04, manylinux_x86_64] | ||
- [ubuntu-22.04, musllinux_x86_64] | ||
- [macos-12, macosx_*] | ||
- [macos-12, macosx_x86_64] | ||
# Note: M1 images on Github Actions start from macOS 14 | ||
- [macos-14, macosx_arm64] | ||
- [windows-2022, win_amd64] | ||
# TODO: support PyPy? | ||
python: [["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"], ["cp312", "3.12"]] | ||
|
@@ -128,7 +130,7 @@ jobs: | |
# Python version used to build sdist doesn't matter | ||
# wheel will be built from sdist with the correct version | ||
- name: Unzip sdist (macOS) | ||
if: ${{ matrix.buildplat[1] == 'macosx_*' }} | ||
if: ${{ startsWith(matrix.buildplat[1], 'macosx') }} | ||
run: | | ||
tar -xzf ./dist/${{ env.sdist_name }} -C ./dist | ||
|
||
|
@@ -137,11 +139,15 @@ jobs: | |
shell: bash -el {0} | ||
run: echo "sdist_name=$(cd ./dist && ls -d */)" >> "$GITHUB_ENV" | ||
|
||
- name: Install pipx | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you link actions/runner-images#9256? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like cibuildwheel folks were already on it - a version bump should do the trick. |
||
if: ${{ matrix.buildplat[1] == 'macosx_arm64' }} | ||
run: brew install pipx && pipx ensurepath | ||
|
||
- name: Build normal wheels | ||
if: ${{ (env.IS_SCHEDULE_DISPATCH != 'true' || env.IS_PUSH == 'true') }} | ||
uses: pypa/[email protected] | ||
with: | ||
package-dir: ./dist/${{ matrix.buildplat[1] == 'macosx_*' && env.sdist_name || needs.build_sdist.outputs.sdist_file }} | ||
package-dir: ./dist/${{ startsWith(matrix.buildplat[1], 'macosx') && env.sdist_name || needs.build_sdist.outputs.sdist_file }} | ||
env: | ||
CIBW_PRERELEASE_PYTHONS: True | ||
CIBW_BUILD: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }} | ||
|
@@ -150,7 +156,7 @@ jobs: | |
if: ${{ (env.IS_SCHEDULE_DISPATCH == 'true' && env.IS_PUSH != 'true') }} | ||
uses: pypa/[email protected] | ||
with: | ||
package-dir: ./dist/${{ matrix.buildplat[1] == 'macosx_*' && env.sdist_name || needs.build_sdist.outputs.sdist_file }} | ||
package-dir: ./dist/${{ startsWith(matrix.buildplat[1], 'macosx') && env.sdist_name || needs.build_sdist.outputs.sdist_file }} | ||
env: | ||
# The nightly wheels should be build witht he NumPy 2.0 pre-releases | ||
# which requires the additional URL. | ||
|
@@ -191,7 +197,7 @@ jobs: | |
|
||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: ${{ matrix.python[0] }}-${{ startsWith(matrix.buildplat[1], 'macosx') && 'macosx' || matrix.buildplat[1] }} | ||
name: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }} | ||
path: ./wheelhouse/*.whl | ||
|
||
- name: Upload wheels & sdist | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great we don't need this anymore!