-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Add macOS M1 CI #57163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add macOS M1 CI #57163
Conversation
@@ -227,8 +228,7 @@ jobs: | |||
PANDAS_CI: 1 | |||
PYTEST_TARGET: pandas | |||
PATTERN: "not slow and not db and not network and not single_cpu" | |||
# GH 47443: PYTEST_WORKERS > 0 crashes Windows builds with memory related errors | |||
PYTEST_WORKERS: ${{ matrix.os == 'macos-latest' && 'auto' || '0' }} | |||
PYTEST_WORKERS: 'auto' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great we don't need this anymore!
.github/workflows/wheels.yml
Outdated
@@ -137,11 +139,15 @@ jobs: | |||
shell: bash -el {0} | |||
run: echo "sdist_name=$(cd ./dist && ls -d */)" >> "$GITHUB_ENV" | |||
|
|||
- name: Install pipx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you link actions/runner-images#9256?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like cibuildwheel folks were already on it - a version bump should do the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ex @mroeschke comments
self-merging as this is green. As always, happy to address comments in a followup. |
Backport PR #57163: CI: Add macOS M1 CI Co-authored-by: Thomas Li <[email protected]>
* CI: Start testing on M1 * install pytest-localserver from pip * typo * more CI adjustments and try to fix wheel builders * more fixes * auto workers on windows as well * fix wheel builders * Update wheels.yml * bump cibuildwheel * bump both * maybe fix windows as well
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.