Skip to content

CI: Add macOS M1 CI #57163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 2, 2024
Merged

CI: Add macOS M1 CI #57163

merged 12 commits into from
Feb 2, 2024

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jan 31, 2024

@lithomas1 lithomas1 added CI Continuous Integration OS X Related to Mac OS & hardware issues (M1) Build Library building on various platforms labels Jan 31, 2024
@lithomas1 lithomas1 marked this pull request as ready for review January 31, 2024 04:52
@lithomas1 lithomas1 requested a review from mroeschke as a code owner January 31, 2024 04:52
@@ -227,8 +228,7 @@ jobs:
PANDAS_CI: 1
PYTEST_TARGET: pandas
PATTERN: "not slow and not db and not network and not single_cpu"
# GH 47443: PYTEST_WORKERS > 0 crashes Windows builds with memory related errors
PYTEST_WORKERS: ${{ matrix.os == 'macos-latest' && 'auto' || '0' }}
PYTEST_WORKERS: 'auto'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great we don't need this anymore!

@@ -137,11 +139,15 @@ jobs:
shell: bash -el {0}
run: echo "sdist_name=$(cd ./dist && ls -d */)" >> "$GITHUB_ENV"

- name: Install pipx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link actions/runner-images#9256?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like cibuildwheel folks were already on it - a version bump should do the trick.

@lithomas1 lithomas1 added this to the 2.2.1 milestone Jan 31, 2024
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ex @mroeschke comments

@lithomas1 lithomas1 merged commit 1d1672d into pandas-dev:main Feb 2, 2024
@lithomas1 lithomas1 deleted the add-m1-ci branch February 2, 2024 00:53
@lithomas1
Copy link
Member Author

self-merging as this is green.

As always, happy to address comments in a followup.

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 2, 2024
mroeschke pushed a commit that referenced this pull request Feb 2, 2024
Backport PR #57163: CI: Add macOS M1 CI

Co-authored-by: Thomas Li <[email protected]>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* CI: Start testing on M1

* install pytest-localserver from pip

* typo

* more CI adjustments and try to fix wheel builders

* more fixes

* auto workers on windows as well

* fix wheel builders

* Update wheels.yml

* bump cibuildwheel

* bump both

* maybe fix windows as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration OS X Related to Mac OS & hardware issues (M1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/PERF: Windows builds fail due to potential MemoryErrors
3 participants