Skip to content

BUG: Bug in fillna with Series and a passed series/dict (GH5703) #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2013

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Dec 15, 2013

closes #5703

In [1]: s1 = Series([np.nan])

In [2]: s2 = Series([1])

In [3]: s1.fillna(s2)
Out[3]: 
0    1
dtype: float64

In [4]: s1.fillna({ 1 : 1})
Out[4]: 
0    1
dtype: float64

In [5]: s1.fillna({ 1 : 2, 2 : 3})

ValueError: cannot fillna on a 1-dim object with more than one value

jreback added a commit that referenced this pull request Dec 16, 2013
BUG: Bug in fillna with Series and a passed series/dict (GH5703)
@jreback jreback merged commit 986bda2 into pandas-dev:master Dec 16, 2013
@jorisvandenbossche
Copy link
Member

@jreback I think with this change also the docstring should be updated? Because a Series is not mentioned now.

@jreback
Copy link
Contributor Author

jreback commented Dec 16, 2013

hmm thought it was

@jreback
Copy link
Contributor Author

jreback commented Dec 17, 2013

@jorisvandenbossche docs updated in #5716

@jorisvandenbossche
Copy link
Member

@jreback Super!

@attack68 attack68 mentioned this pull request Jan 22, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series.fillna doesn't work with series input
2 participants