Skip to content

add test for fillna with column #39323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hasandiwan
Copy link

  • tests added / passed

I noticed there was no test for pd.Series.fillna using a column, so I added one.

@pep8speaks
Copy link

Hello @hasandiwan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 24:38: E231 missing whitespace after ','
Line 24:41: E231 missing whitespace after ','
Line 32:1: W293 blank line contains whitespace

@attack68
Copy link
Contributor

are you sure this is not already solved by #5703 and PR #5705? The tests seem there already.

@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

closing this as stale

@jreback jreback closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants