Skip to content

Update indexing unpacking logic for single block case #56209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2023
+7 −7
Merged

Update indexing unpacking logic for single block case #56209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a43b737
Update indexing unpacking logic for single block case
phofl Nov 27, 2023
5612ac1
Merge branch 'main' into indexing_update
phofl Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pandas/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,6 +2140,12 @@ def _setitem_single_block(self, indexer, value, name: str) -> None:
"""
from pandas import Series

if (isinstance(value, ABCSeries) and name != "iloc") or isinstance(value, dict):
# TODO(EA): ExtensionBlock.setitem this causes issues with
# setting for extensionarrays that store dicts. Need to decide
# if it's worth supporting that.
value = self._align_series(indexer, Series(value))

info_axis = self.obj._info_axis_number
item_labels = self.obj._get_axis(info_axis)
if isinstance(indexer, tuple):
Expand All @@ -2160,13 +2166,7 @@ def _setitem_single_block(self, indexer, value, name: str) -> None:

indexer = maybe_convert_ix(*indexer) # e.g. test_setitem_frame_align

if (isinstance(value, ABCSeries) and name != "iloc") or isinstance(value, dict):
# TODO(EA): ExtensionBlock.setitem this causes issues with
# setting for extensionarrays that store dicts. Need to decide
# if it's worth supporting that.
value = self._align_series(indexer, Series(value))

elif isinstance(value, ABCDataFrame) and name != "iloc":
if isinstance(value, ABCDataFrame) and name != "iloc":
value = self._align_frame(indexer, value)._values

# check for chained assignment
Expand Down