Skip to content

Update indexing unpacking logic for single block case #56209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2023
Merged

Update indexing unpacking logic for single block case #56209

merged 2 commits into from
Nov 29, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 27, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl
Copy link
Member Author

phofl commented Nov 27, 2023

cc @MarcoGorelli

this seems to pass locally on the subset that I am usually running

MarcoGorelli
MarcoGorelli approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this helps, thanks!

@mroeschke mroeschke added this to the 2.2 milestone Nov 29, 2023
@mroeschke mroeschke added the Internals Related to non-user accessible pandas implementation label Nov 29, 2023
@mroeschke mroeschke merged commit 0e8174f into pandas-dev:main Nov 29, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the indexing_update branch November 29, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @mroeschke @MarcoGorelli