-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix get_datetimestruct_days overflow #56001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−19
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ef1a588
remove pandas/tests/frame UB
WillAyd b2b492a
updated macro with filename / line num
WillAyd 57dbe81
Merge branch 'main' into fix-dt-overflow
WillAyd 13cb7e5
fix typo
WillAyd e51d4f9
Merge branch 'main' into fix-dt-overflow
WillAyd d2a1014
stay with PD_CHECK_OVERFLOW
WillAyd 842b7c1
updates
WillAyd 1ba2259
Merge branch 'main' into fix-dt-overflow
WillAyd 2ecfea0
test fixes
WillAyd 0c33d5c
Merge branch 'main' into fix-dt-overflow
WillAyd e3116c3
Merge branch 'main' into fix-dt-overflow
mroeschke 9d37245
Merge branch 'main' into fix-dt-overflow
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is acquiring the gil, checking if an overflow happened, then releasing it? is there a nogil alternative?
id be more comfortable with this if we had a test where it made a difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GIL is only acquired when
days == -1
because you need to check if that is a legitimate value or if a Python exception was thrown. This is essentially whatexcept? -1
does in Cython