Fix get_datetimestruct_days overflow #56001
Conversation
|
|
||
| if (did_overflow) { |
There was a problem hiding this comment.
We could also just PD_CHECK_OVERFLOW every expression but that is potentially a lot of branching. This allows more calls to build up in a pipeline and just raises at the very end if needed
mroeschke
added
the
Internals
| if (did_error) { | ||
| return -1; | ||
| } | ||
| } |
There was a problem hiding this comment.
this is acquiring the gil, checking if an overflow happened, then releasing it? is there a nogil alternative?
id be more comfortable with this if we had a test where it made a difference
There was a problem hiding this comment.
The GIL is only acquired when days == -1 because you need to check if that is a legitimate value or if a Python exception was thrown. This is essentially what except? -1 does in Cython
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks @WillAyd |
More pre-cursor for UBSAN/ASAN