TYP/DOC: fix flavor param with incorrect type hint in read_html #55076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
approved these changes
Sep 9, 2023
|
Thanks @matheusfelipeog ! |
|
Thanks for the review and merge @twoertwein. Should pandas-stubs also be updated accordingly? |
|
You are welcome to also open a PR at pandas-stubs |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
Dr-Irv
pushed a commit
to pandas-dev/pandas-stubs
that referenced
this pull request
Nov 2, 2023
* Fix flavor param with incorrect type hint in read_html refs: - pandas-dev/pandas#55059 - pandas-dev/pandas#55076 * Add HTMLFlavors type to read_html ref: pandas-dev/pandas#55529 * Add tests and new dev dependencies Added: - tests to check HTMLFlavors type in read_html flavor arg; - set beautifulsoup4 and html5lib as dev dependencies. They are used by the respective flavors in read_html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #55059