Skip to content

Fix flavor param with incorrect type hint in read_html #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2023
Merged

Fix flavor param with incorrect type hint in read_html #772

merged 4 commits into from
Nov 2, 2023

Conversation

matheusfelipeog
Copy link
Contributor

@twoertwein
Copy link
Member

Please add a test or this change.

@matheusfelipeog
Copy link
Contributor Author

Please add a test or this change.

I don't know if I understood correctly. What type of test case are you talking about?

@twoertwein
Copy link
Member

A test similar to

pandas-stubs/tests/test_io.py

Line 1240 in 6bb1215

def test_read_html():
Pandas-stubs writes test to verify that type checkers pick up the proposed changes (and to prevent regressions).

Dr-Irv
Dr-Irv reviewed Sep 11, 2023
View reviewed changes
@matheusfelipeog matheusfelipeog mentioned this pull request Oct 15, 2023
Merged
matheusfelipeog and others added 3 commits November 2, 2023 04:12
@matheusfelipeog
Add HTMLFlavors type to read_html
3063be8 
ref: pandas-dev/pandas#55529
@matheusfelipeog
Add tests and new dev dependencies
ff5faea 
Added:
- tests to check HTMLFlavors type in read_html flavor arg;
- set beautifulsoup4 and html5lib as dev dependencies. They are used
by the respective flavors in read_html.
@matheusfelipeog
Merge branch 'main' into fix/incorrect-flavor-type-hint
e439ccd
@matheusfelipeog
Copy link
Contributor Author

Done, @twoertwein and @Dr-Irv.

The PR pandas-dev/pandas#55529 adding the HTMLFlavors type has been approved in the pandas repository. As discussed, I've updated it here to align with it.

Dr-Irv
Dr-Irv approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @matheusfelipeog

@Dr-Irv Dr-Irv merged commit 717f4dd into pandas-dev:main Nov 2, 2023
@matheusfelipeog matheusfelipeog deleted the fix/incorrect-flavor-type-hint branch November 2, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheusfelipeog @twoertwein @Dr-Irv