BUG: Fix Rolling where duplicate datetimelike indexes are treated as consecutive rather than equal with closed='left' and closed='neither' #54917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsansecer
commented
Sep 1, 2023
| @@ -466,20 +466,23 @@ def test_groupby_rolling_subset_with_closed(self): | |||
| # GH 35549 | |||
| df = DataFrame( | |||
| { | |||
| "column1": range(6), | |||
There was a problem hiding this comment.
Modified these two tests as the result would be list of nan values
mroeschke
reviewed
Sep 1, 2023
pandas/_libs/window/indexers.pyx
Outdated
| @@ -138,7 +138,12 @@ def calculate_variable_window_bounds( | |||
| break | |||
| # end bound is previous end | |||
| # or current index | |||
| elif (index[end[i - 1]] - end_bound) * index_growth_sign <= 0: | |||
| elif index[end[i - 1]] == end_bound: | |||
There was a problem hiding this comment.
Could you make a similar test for VariableOffsetWindowIndexer.get_window_bounds and include a test?
mroeschke
approved these changes
Sep 5, 2023
|
Thanks @ihsansecer |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
…consecutive rather than equal with closed='left' and closed='neither' (pandas-dev#54917) * Add bugfix for rolling window with nonunique datetimelike index * Run black * Add entry to whatsnew * Fix VariableOffsetWindowIndexer * Simplify change in indexers.pyx * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.0.rstfile if fixing a bug or adding a new feature.