Skip to content

REF: simplify extension reduction tests #54394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

jbrockmendel
Copy link
Member

Will clean up the pyarrow tests usage in a follow-up.

Didn't remove the no-longer-used test classes since downstream projects might be using them. Are we OK just ripping those out or does that require a deprecation cycle?

@mroeschke
Copy link
Member

Are we OK just ripping those out or does that require a deprecation cycle?

Probably should deprecate them since we advertise users to test with them, but since it's not extremely public maybe we can do a 3.0 change?

@jbrockmendel
Copy link
Member Author

Probably should deprecate them since we advertise users to test with them, but since it's not extremely public maybe we can do a 3.0 change?

Works for me

@jbrockmendel
Copy link
Member Author

Probably should deprecate them since we advertise users to test with them, but since it's not extremely public maybe we can do a 3.0 change?

Just checking: you mean OK to move forward with this PR as is then remove the old classes in 3.0?

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Aug 4, 2023
@mroeschke mroeschke added this to the 2.1 milestone Aug 4, 2023
@mroeschke
Copy link
Member

you mean OK to move forward with this PR as is then remove the old classes in 3.0?

Yeah I think deprecating tests is sticky business and probably just worth noting in 3.0 to use a different test class

@mroeschke mroeschke merged commit 7bc2000 into pandas-dev:main Aug 4, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-tst-reduce branch August 5, 2023 01:03
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: extension tests BaseNoReduceTests/BaseBooleanReduceTests is confusing
2 participants