Skip to content

API: extension tests BaseNoReduceTests/BaseBooleanReduceTests is confusing #44742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Dec 3, 2021 · 1 comment · Fixed by #54394
Closed

API: extension tests BaseNoReduceTests/BaseBooleanReduceTests is confusing #44742

jbrockmendel opened this issue Dec 3, 2021 · 1 comment · Fixed by #54394
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Dec 3, 2021 •
edited
Loading

Could maybe have one class for this and a class attribute implements = ["any", "all", ...]?
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 3, 2021
@mroeschke mroeschke added ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 27, 2021
@jbrockmendel jbrockmendel mentioned this issue Dec 12, 2022
Merged
5 tasks
@jbrockmendel
Copy link
Member Author

Same for test_accumulate_series_raises and test_accumulate_series

This was referenced Aug 3, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: simplify extension reduction tests jbrockmendel/pandas
2 participants
@jbrockmendel @mroeschke