DISC: One big Extension Test class #54420
Labels
ExtensionArray
Extending pandas with custom dtypes or arrays.
Testing
pandas testing functions or related to the test suite
I've been trying to improve the situation in tests/extension with the goals being
One pain point I'm finding is that there are 23 test classes exposed in tests.extension.base and authors are supposed to subclass most of them, a few being optional (and some being mutually exclusive xref #44742). This introduces some failure modes:
1a) e.g. in test_interval I see 14 test classes. I hope the others are excluded intentionally, but don't really know.
1b) If we introduce a new test class (e.g. i think the BaseAccumulateTests is relatively recent) an existing EA might not know it needs updating
I think it would be a better author/maintainer experience if we had all those test classes inherited into one TestExtensionArray class that authors (and our own EA tests) inherit. The downside is backward compatibility for existing 3rd party test suites. I guess we could continue to expose the separate classes, potentially deprecate them. The main trouble would be the mutually-exclusive ones.
Thoughts?
The text was updated successfully, but these errors were encountered: