Skip to content

TST: Don't cast in test_cython_agg_nullable_int #54248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2023
Merged

TST: Don't cast in test_cython_agg_nullable_int #54248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88268b0
TST: Don't cast in test_cython_agg_nullable_int
mroeschke Jul 24, 2023
ed1acb3
Merge remote-tracking branch 'upstream/main' into tst/gb/nullable
mroeschke Jul 25, 2023
7af6291
keep np dtype and cast
mroeschke Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pandas/tests/groupby/aggregate/test_cython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,13 +338,11 @@ def test_cython_agg_nullable_int(op_name):
result = getattr(df.groupby("A")["B"], op_name)()
df2 = df.assign(B=df["B"].astype("float64"))
expected = getattr(df2.groupby("A")["B"], op_name)()

if op_name != "count":
# the result is not yet consistently using Int64/Float64 dtype,
# so for now just checking the values by casting to float
result = result.astype("float64")
if op_name in ("mean", "median"):
convert_integer = False
else:
result = result.astype("int64")
convert_integer = True
expected = expected.convert_dtypes(convert_integer=convert_integer)
tm.assert_series_equal(result, expected)


Expand Down