TST: Don't cast in test_cython_agg_nullable_int #54248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
rhshadrach
reviewed
Jul 25, 2023
| @@ -336,15 +336,9 @@ def test_cython_agg_nullable_int(op_name): | |||
| } | |||
| ) | |||
| result = getattr(df.groupby("A")["B"], op_name)() | |||
| df2 = df.assign(B=df["B"].astype("float64")) | |||
| df2 = df.assign(B=df["B"]) | |||
There was a problem hiding this comment.
I think we want to still use NumPy dtypes here, then cast expected to the expected nullable dtype.
There was a problem hiding this comment.
Ah okay. I put back this cast and used convert_dtypes to cast expected to the nullable dtype
|
Thanks @mroeschke |
rhshadrach
added
the
NA - MaskedArrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref https://github.com/pandas-dev/pandas/pull/54129/files#r1272774080
Nice find @rhshadrach!