Skip to content

ENH: Don't fragment manager if convert is no-op #53977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2023
Merged

ENH: Don't fragment manager if convert is no-op #53977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de485b9
ENH: Don't fragment manager if convert is no-op
phofl Jul 2, 2023
c782c9a
Update
phofl Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pandas/core/internals/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,15 @@ def convert(
return [self.copy()] if copy else [self]

if self.ndim != 1 and self.shape[0] != 1:
return self.split_and_operate(Block.convert, copy=copy, using_cow=using_cow)
blocks = self.split_and_operate(
Block.convert, copy=copy, using_cow=using_cow
)
if all(blk.dtype.kind == "O" for blk in blocks):
# Avoid fragmenting the block if convert is a no-op
if using_cow:
return [self.copy(deep=False)]
return [self.copy()] if copy else [self]
return blocks

values = self.values
if values.ndim == 2:
Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/frame/methods/test_replace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1592,3 +1592,10 @@ def test_replace_categorical_no_replacement(self):

result = df.replace(to_replace=[".", "def"], value=["_", None])
tm.assert_frame_equal(result, expected)

def test_replace_object_splitting(self):
# GH#53977
df = DataFrame({"a": ["a"], "b": "b"})
assert len(df._mgr.blocks) == 1
df.replace(to_replace=r"^\s*$", value="", inplace=True, regex=True)
assert len(df._mgr.blocks) == 1