ENH: Don't fragment manager if convert is no-op #53977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Jul 3, 2023
jbrockmendel
reviewed
Jul 3, 2023
| @@ -1592,3 +1592,10 @@ def test_replace_categorical_no_replacement(self): | |||
|
|
|||
| result = df.replace(to_replace=[".", "def"], value=["_", None]) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_replace_object_splitting(self): | |||
| # GH# | |||
jbrockmendel
approved these changes
Jul 3, 2023
phofl
added
Performance
|
This feels a bit too deep in the internals for a whatsnew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel thoughts here? This isn't ideal but since this is probably the code path that's taken 99% of the time this might make sense?