Skip to content

Update offset prefix map #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update offset prefix map #5383

wants to merge 2 commits into from

Conversation

patricktokeeffe
Copy link
Contributor

This should address issue #5382

Ties prefix map to `__all__` so future updates are automatic
@patricktokeeffe
Copy link
Contributor Author

I tried setting up Travis but can't tell if it's working. didn't turn on the service hook before pushing. Locally I ran nosetests pandas but I don't know what to think of the results:

Base case - master (d0342aa) 2013-10-27 20:26:02

Ran 4331 tests in 384.605s

FAILED (SKIP=318, failures=1)

Test case - update-offset-prefix-map branch (a2cc230)

Ran 2977 tests in 190.863s

FAILED (SKIP=156, errors=1064, failures=1)

@jtratner
Copy link
Contributor

Weird that master has a failing test case. It appears that you introduced
some errors such that 1300 tests didn't run and another 1000 tests failed
in some way. Many tests create date indexes as part of their setup, which
may be the problem.

Also, Nano is conditionally added to the offset list based on numpy version.

@jreback
Copy link
Contributor

jreback commented Oct 30, 2013

@patricktokeeffe and generally doing something based on the import, e.g. __all__ is not a nice way way of doing things

@patricktokeeffe
Copy link
Contributor Author

Ok. Looks like the only missing one then is LastWeekOfMonth and since it appears to be WIP (#4637) this PR is irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants