Skip to content

LastWeekOfMonth DateOffset #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cancan101 opened this issue Aug 22, 2013 · 5 comments
Closed

LastWeekOfMonth DateOffset #4637

cancan101 opened this issue Aug 22, 2013 · 5 comments
Labels
Milestone

Comments

@cancan101
Copy link
Contributor

Create a DateOffset that represents the a weekday in last week of the month, such as "the last Tuesday of each month"

Currently there is a WeekOfMonth DateOffset but that class only takes week : {0, 1, 2, 3, ...}. What we actually want is week=-1

I will submit a PR.

@jreback
Copy link
Contributor

jreback commented Aug 22, 2013

I added a 'Frequency' label to tag some of these issues

@cancan101
Copy link
Contributor Author

@jreback I have a PR in progress for this. It's part of #4511

@patricktokeeffe
Copy link
Contributor

I'm curious why this was implemented as a new class instead of extending the range for WeekOfMonth into the negative range. It seems valid enough to say "the second to last Tuesday of each month" or week=-2.

@cancan101
Copy link
Contributor Author

I don't think there is a good reason. I would not be averse to just merging that functionality into WeekOfMonth

@jreback
Copy link
Contributor

jreback commented Feb 18, 2014

closed by #5004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants