-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: Remove literal string input for read_html #53805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 6 commits into
pandas-dev:main
from
rmhowe425:dev/depr/literal-str-read_html
Jun 28, 2023
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8cade5
Updating documentation and adding deprecation logic for read_html.
rmhowe425 6c39ea8
Fixing formatting errors
rmhowe425 cdd27e2
Fixing documentation errors
rmhowe425 808bf3f
Merge branch 'main' into dev/depr/literal-str-read_html
rmhowe425 f6f22b4
Updating deprecation logic and documentation per reviewer recommendat…
rmhowe425 0e6176e
Updating implementation per reviewer recommendations.
rmhowe425 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,13 +17,15 @@ | |
Sequence, | ||
cast, | ||
) | ||
import warnings | ||
|
||
from pandas._libs import lib | ||
from pandas.compat._optional import import_optional_dependency | ||
from pandas.errors import ( | ||
AbstractMethodError, | ||
EmptyDataError, | ||
) | ||
from pandas.util._exceptions import find_stack_level | ||
from pandas.util._validators import check_dtype_backend | ||
|
||
from pandas.core.dtypes.common import is_list_like | ||
|
@@ -1023,6 +1025,9 @@ def read_html( | |
lxml only accepts the http, ftp and file url protocols. If you have a | ||
URL that starts with ``'https'`` you might try removing the ``'s'``. | ||
|
||
.. deprecated:: 2.1.0 | ||
Passing html literal strings is deprecated. | ||
|
||
match : str or compiled regular expression, optional | ||
The set of tables containing text matching this regex or string will be | ||
returned. Unless the HTML is extremely simple you will probably need to | ||
|
@@ -1178,6 +1183,15 @@ def read_html( | |
|
||
io = stringify_path(io) | ||
|
||
if isinstance(io, str) and "\n" in io: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is |
||
warnings.warn( | ||
"Passing literal html to 'read_html' is deprecated and " | ||
"will be removed in a future version. To read from a " | ||
"literal string, wrap it in a 'StringIO' object.", | ||
FutureWarning, | ||
stacklevel=find_stack_level(), | ||
) | ||
|
||
return _parse( | ||
flavor=flavor, | ||
io=io, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.