DEPR: Remove literal string input for read_html #53805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke PR is ready for inspection! |
mroeschke
added
IO HTML
mroeschke
reviewed
Jun 26, 2023
doc/source/whatsnew/v2.1.0.rst
Outdated
| @@ -298,13 +298,15 @@ Deprecations | |||
| - Deprecated constructing :class:`SparseArray` from scalar data, pass a sequence instead (:issue:`53039`) | |||
| - Deprecated falling back to filling when ``value`` is not specified in :meth:`DataFrame.replace` and :meth:`Series.replace` with non-dict-like ``to_replace`` (:issue:`33302`) | |||
| - Deprecated literal json input to :func:`read_json`. Wrap literal json string input in ``io.StringIO`` instead. (:issue:`53409`) | |||
| - Deprecated literal string/bytes input to :func:`read_html`. Wrap literal string/bytes input in ``io.StringIO`` instead. (:issue:`53767`) | |||
There was a problem hiding this comment.
Suggested change
| - Deprecated literal string/bytes input to :func:`read_html`. Wrap literal string/bytes input in ``io.StringIO`` instead. (:issue:`53767`) | |
| - Deprecated literal string/bytes input to :func:`read_html`. Wrap literal string/bytes input in ``io.StringIO``/``io.BytesIO`` instead. (:issue:`53767`) |
mroeschke
reviewed
Jun 26, 2023
pandas/io/html.py
Outdated
| @@ -1178,6 +1183,15 @@ def read_html( | |||
|
|
|||
| io = stringify_path(io) | |||
|
|
|||
| if isinstance(io, str) and "\n" in io: | |||
There was a problem hiding this comment.
Is \n a reliable way detect if it's literal html?
mroeschke
reviewed
Jun 27, 2023
pandas/io/html.py
Outdated
| @@ -1178,6 +1185,15 @@ def read_html( | |||
|
|
|||
| io = stringify_path(io) | |||
|
|
|||
| if isinstance(io, str) and not is_file_like(io) and "\n" in io: | |||
There was a problem hiding this comment.
Could use the same type of checks like in the xml PR and remove the \n check?
|
@mroeschke PR is ready for inspection. |
mroeschke
approved these changes
Jun 28, 2023
|
Thanks @rmhowe425 |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Updating documentation and adding deprecation logic for read_html. * Fixing formatting errors * Fixing documentation errors * Updating deprecation logic and documentation per reviewer recommendations. * Updating implementation per reviewer recommendations.
debnath-d
added a commit
to debnath-d/ISLP
that referenced
this pull request
Apr 30, 2024
See: pandas-dev/pandas#53805 Passing html literal strings is deprecated. Wrap literal string/bytes input in ``io.StringIO``/``io.BytesIO`` instead.
jonathan-taylor
pushed a commit
to intro-stat-learning/ISLP
that referenced
this pull request
Jun 4, 2024
See: pandas-dev/pandas#53805 Passing html literal strings is deprecated. Wrap literal string/bytes input in ``io.StringIO``/``io.BytesIO`` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_excel,read_html, andread_xml#53767doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.