Skip to content

DEPR: use_inf_as_na #53494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 6, 2023
Merged

DEPR: use_inf_as_na #53494

merged 6 commits into from
Jun 6, 2023

Conversation

jbrockmendel
Copy link
Member

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Jun 1, 2023
@mroeschke
Copy link
Member 

2023-06-01T20:16:55.9250397Z docstring of pandas.reset_option:305: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2023-06-01T20:16:55.9251576Z docstring of pandas.set_option:310: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2023-06-01T20:16:55.9254260Z docstring of pandas.describe_option:310: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2023-06-01T20:16:55.9255238Z docstring of pandas.get_option:307: WARNING: Explicit markup ends without a blank line; unexpected unindent.

@jbrockmendel
Copy link
Member Author

It isn't clear to me what those docbuild complaints are pointing to.

mroeschke
mroeschke reviewed Jun 1, 2023
View reviewed changes
pandas/core/config_init.py Outdated
@@ -411,6 +411,8 @@ def is_terminal() -> bool:
True means treat None, NaN, INF, -INF as NA (old way),
False means None and NaN are null, but INF, -INF are not NA
(new way).

.. deprecated:: 2.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the line that the doc build is complaining about. Maybe put it as the first line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm that didnt seem to help

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this is handled now

@mroeschke mroeschke added this to the 2.1 milestone Jun 6, 2023
@mroeschke mroeschke merged commit 2b69700 into pandas-dev:main Jun 6, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-use_inf_as_na branch June 6, 2023 18:09
This was referenced Jun 7, 2023
Closed
Closed
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@jbrockmendel
DEPR: use_inf_as_na (pandas-dev#53494)
17cd454 
* DEPR: use_inf_as_na

* troubleshoot doc

* troubleshoot docbuild

* troubleshoot doc

* troubleshoot docs
This was referenced Feb 14, 2024
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DEPR: use_inf_as_na
2 participants
@jbrockmendel @mroeschke