Skip to content

DEPR: use_inf_as_na #51684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Feb 28, 2023 · 2 comments · Fixed by #53494
Closed

DEPR: use_inf_as_na #51684

jbrockmendel opened this issue Feb 28, 2023 · 2 comments · Fixed by #53494
Labels
Deprecate Functionality to remove in pandas

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Feb 28, 2023 •
edited
Loading

Support for use_inf_as_na isn't great, it performs poorly, and we don't have any way to make EAs respect it. Is this worth keeping?
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member Deprecate Functionality to remove in pandas Needs Discussion Requires discussion from core team before further action and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 28, 2023
@mroeschke mroeschke mentioned this issue Apr 6, 2023
Closed
3 tasks
@mahmoudmarayef
Copy link

We can convert infinity values to NaN before processing: Instead of relying on the use_inf_as_na parameter, you can manually convert infinity values to NaN before processing the data. This can be done using the replace method in pandas.

@jbrockmendel
Copy link
Member Author

Discussed on last week's dev call, consensus was +1 to deprecate.

@jbrockmendel jbrockmendel removed the Needs Discussion Requires discussion from core team before further action label May 30, 2023
@jbrockmendel jbrockmendel mentioned this issue Jun 1, 2023
Merged
5 tasks
@ChengjieLi28 ChengjieLi28 mentioned this issue Sep 11, 2023
Merged
2 tasks
@akihironitta akihironitta mentioned this issue Oct 11, 2023
Merged
weihua916 pushed a commit to pyg-team/pytorch-frame that referenced this issue Oct 11, 2023
@akihironitta
Move model to device and don't use deprecated use_inf_as_na (#104)
bee4252 
This PR includes fixes for:
- running `examples/tutorial.py` on a cuda device
- suppressing these countless warnings introduced by
pandas-dev/pandas#51684:
  ```

/home/akihiro/work/github.com/pyg-team/pytorch-frame/torch_frame/data/stats.py:60:
FutureWarning: use_inf_as_na option is deprecated and will be removed in
a future version. Convert inf values to NaN before operating instead.
  ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: use_inf_as_na jbrockmendel/pandas
2 participants
@jbrockmendel @mahmoudmarayef