Skip to content

fix documentation build error in basics.rst #53398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2023
Merged

fix documentation build error in basics.rst #53398

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07f6ff
fix documentation build error in basics.rst
DominikBerger01 May 26, 2023
adcb03e
remove need for seed and gen random np array from range (0,255)
DominikBerger01 May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/source/user_guide/basics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2121,6 +2121,9 @@ different numeric dtypes will **NOT** be combined. The following example will gi

.. ipython:: python

@suppress
np.random.seed(2358)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is quite right (since the code below should work for all seeds).

A better fix would be to replace the np.random.randn call with something that generates random integers in the range of [0,255] (range of uint8).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. I'll update the pull request.
Regards,
Dominik


df1 = pd.DataFrame(np.random.randn(8, 1), columns=["A"], dtype="float32")
df1
df1.dtypes
Expand Down