fix documentation build error in basics.rst #53398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
reviewed
May 26, 2023
doc/source/user_guide/basics.rst
Outdated
| @@ -2121,6 +2121,9 @@ different numeric dtypes will **NOT** be combined. The following example will gi | |||
|
|
|||
| .. ipython:: python | |||
|
|
|||
| @suppress | |||
| np.random.seed(2358) | |||
There was a problem hiding this comment.
I don't think this is quite right (since the code below should work for all seeds).
A better fix would be to replace the np.random.randn call with something that generates random integers in the range of [0,255] (range of uint8).
There was a problem hiding this comment.
Thank you for your feedback. I'll update the pull request.
Regards,
Dominik
lithomas1
approved these changes
May 26, 2023
mroeschke
approved these changes
May 30, 2023
|
Thanks @DominikBerger01 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
May 30, 2023
mroeschke
added a commit
that referenced
this pull request
May 30, 2023
…basics.rst) (#53456) * Backport PR #53398: fix documentation build error in basics.rst * Update doc/source/user_guide/basics.rst --------- Co-authored-by: Dominik Berger <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]>
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
* fix documentation build error in basics.rst * remove need for seed and gen random np array from range (0,255)
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* fix documentation build error in basics.rst * remove need for seed and gen random np array from range (0,255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC: fix documentation build error in basics.rst based on #53354
building with
python make.py --single user_guide/basics.rstnow works without issues
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.