Skip to content

DEPR: infer bytes to bytes[pyarrow] #53357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from

Conversation

jbrockmendel
Copy link
Member

Sits on top of #53025 and #53165.

Inferring bytes causes a few failures that need to be worked out before this is merged.

  • in the string accessors there is a workaround for _str_map, used for .decode
  • test_to_hdf_errors afils with "UnicodeEncodeError: 'utf-8' codec can't encode character '\ud800' in position 0: surrogates not allowed"
  • 3 of the SAS tests fail bc "expected" is constructed with objects.astype('string[pyarrow]') which isn't what we get with bytes_pyarrow.str.decode(...)
  • similar failure for test_decode_errors_kwarg
  • test_astype_unicode fails with UnicodeDecodeError

@jbrockmendel jbrockmendel added Dtype Conversions Unexpected or buggy dtype conversions Deprecate Functionality to remove in pandas Arrow pyarrow functionality labels May 23, 2023
@jbrockmendel jbrockmendel force-pushed the poc-future-bytes branch 2 times, most recently from 087a6a6 to f2bbb48 Compare June 5, 2023 19:55
@jbrockmendel jbrockmendel requested a review from WillAyd as a code owner June 5, 2023 19:55
@jbrockmendel
Copy link
Member Author

mothballing until after (at least) #53165

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions Mothballed Temporarily-closed PR the author plans to return to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant