POC/DEPR: infer time objects to ArrowDtype[time] #53025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Deprecate
This was referenced May 4, 2023
jbrockmendel
force-pushed
the
poc-future
branch
3 times, most recently
from
045feec to
98e3afd
Compare
This was referenced May 23, 2023
jbrockmendel
force-pushed
the
poc-future
branch
3 times, most recently
from
cdef497 to
68543ee
Compare
5 tasks
5 tasks
|
Since the string version of this is in, this POC is no longer needed. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #52711 this is what I have in mind for how we would deprecate the current inference behavior with a sequence of
datetime.timeobjects. We would allow opting-in to the future behavior withpd.set_option("future.infer_time", True).I plan to update this PR to also deprecate returning object dtype from the
timeandtimetzproperties in the.dtaccessor. Also any relevant cases in the sql code.If we go down this route, I would follow this with analogous PRs for datetime.date, Decimal, ...