DOC fix collapsing using new bootstrap v5 API #53209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/53209/ |
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/53209/ |
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/53209/ |
jorisvandenbossche
approved these changes
May 15, 2023
mroeschke
approved these changes
May 15, 2023
|
Thanks @glemaitre |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* DOC fix collapsing using new bootstrap v5 API * FIX use visible button in both dark and light theme * iter
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* DOC fix collapsing using new bootstrap v5 API * FIX use visible button in both dark and light theme * iter
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* DOC fix collapsing using new bootstrap v5 API * FIX use visible button in both dark and light theme * iter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev version of the documentation is broken: the collapse buttons of the table in the "Intro to pandas" are not responsive.
This is linked to an update of the
pydata-sphinx-themefrom 0.11 to 0.13 (#53029) that uses Bootstrap v5 that does not rely anymore on jQuery and renameddata-toogleanddata-targettodata-bs-toogleanddata-bs-target, respectively.In addition,
badge-darkis deprecated in favour ofbadge-dark. However,bg-darkdoes work well with dark theme andbg-secondarydoes a better job.This is a quick fix knowing that a change to
sphinx-designwould allow to removal the pure HTML file.