Skip to content

DEPS: Unpin pydata-sphinx-theme #53029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 11, 2023
Merged

DEPS: Unpin pydata-sphinx-theme #53029

merged 25 commits into from
May 11, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented May 1, 2023 •
edited
Loading

closes #53167

jorisvandenbossche and others added 17 commits March 4, 2022 14:29
@jorisvandenbossche
DOC: migrate from sphinx-panels to sphinx-design
f9f470e
@jorisvandenbossche
Merge remote-tracking branch 'upstream/main' into docs-migrate-sphinx…
4dd8141 
…-design
@jorisvandenbossche
update css for latest pydata-sphinx-theme
344201d
@jorisvandenbossche
add sphinx-design to env
4e3f51d
@jorisvandenbossche
further fix css
be156b9
@mroeschke
Merge branch 'main' into docs-migrate-sphinx-design
9bddaed
@mroeschke
Convert panels to grid, address warning, remove panel dependency
92df06b
@mroeschke
Try addressing failures
3090553
@mroeschke
Merge remote-tracking branch 'upstream/main' into docs-migrate-sphinx…
a4a0353 
…-design
@mroeschke
Fix css
31db3e1
@mroeschke
Fix more css
0bb740d
@mroeschke
Just use one comparison card class
823ca97
@mroeschke
Unpin pydata-sphinx-theme
0bcd79d
@mroeschke
Uncomment other workflows
dbdfc38
@mroeschke
address some warnings
28dae97
@mroeschke
Merge remote-tracking branch 'upstream/main' into deps/pydata-sphinx-pin
9c3c3fa
@mroeschke
Revert "Uncomment other workflows"
bd210bc 
This reverts commit dbdfc38.
@mroeschke mroeschke added CI Continuous Integration Web pandas website labels May 1, 2023
@mroeschke mroeschke added this to the 2.1 milestone May 2, 2023
@datapythonista
Copy link
Member

/preview

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Website preview of this PR available at: https://pandas.pydata.org/preview/53029/

datapythonista
datapythonista reviewed May 3, 2023
View reviewed changes
@mroeschke
Copy link
Member Author

/preview

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Website preview of this PR available at: https://pandas.pydata.org/preview/53029/

@mroeschke @datapythonista
Update doc/source/conf.py
3e9cbb0 
Co-authored-by: Marc Garcia <[email protected]>
@mroeschke
Copy link
Member Author

/preview

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Website preview of this PR available at: https://pandas.pydata.org/preview/53029/

@datapythonista
Copy link
Member

JFYI you can click on the link of the previous /preview comments, it's always the same link, and the command doesn't generate the preview, only the comment with the link for convenience. :) The preview is generated by the docs CI job directly. You don't even need the command if you don't mind typing the url with the PR number.

@mroeschke
Copy link
Member Author

Ah okay sorry I thought the command also had to re-point the link to the latest web artifact.

Thanks for the prior suggestion, the version dropdown seems to work now

@mroeschke mroeschke mentioned this pull request May 10, 2023
Closed
@rhshadrach
Copy link
Member

rhshadrach commented May 10, 2023 •
edited
Loading

When you select 1.5, I'm seeing the docs for 1.5.3:

Date: Nov 22, 2022 Version: 1.5.2

Edit: Ah, this probably isn't relevant here.

@mroeschke
Copy link
Member Author

Yeah I think this is the same behavior that currently happens: https://pandas.pydata.org/pandas-docs/version/1.5/index.html

Since this fixed the doc build issue, going to merge, but happy to address any followups

@mroeschke mroeschke merged commit 3827caf into pandas-dev:main May 11, 2023
@mroeschke mroeschke deleted the deps/pydata-sphinx-pin branch May 11, 2023 01:04
@glemaitre glemaitre mentioned this pull request May 13, 2023
Merged
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@mroeschke @jorisvandenbossche @datapythonista
DEPS: Unpin pydata-sphinx-theme (pandas-dev#53029)
af99ffd 
* DOC: migrate from sphinx-panels to sphinx-design

* update css for latest pydata-sphinx-theme

* add sphinx-design to env

* further fix css

* Convert panels to grid, address warning, remove panel dependency

* Try addressing failures

* Fix css

* Fix more css

* Just use one comparison card class

* Unpin pydata-sphinx-theme

* Uncomment other workflows

* address some warnings

* Revert "Uncomment other workflows"

This reverts commit dbdfc38.

* Change bath to json_url

* Change back to path

* No /

* Change version

* Update doc/source/conf.py

Co-authored-by: Marc Garcia <[email protected]>

---------

Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Marc Garcia <[email protected]>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@mroeschke @jorisvandenbossche @datapythonista
DEPS: Unpin pydata-sphinx-theme (pandas-dev#53029)
bb9575e 
* DOC: migrate from sphinx-panels to sphinx-design

* update css for latest pydata-sphinx-theme

* add sphinx-design to env

* further fix css

* Convert panels to grid, address warning, remove panel dependency

* Try addressing failures

* Fix css

* Fix more css

* Just use one comparison card class

* Unpin pydata-sphinx-theme

* Uncomment other workflows

* address some warnings

* Revert "Uncomment other workflows"

This reverts commit dbdfc38.

* Change bath to json_url

* Change back to path

* No /

* Change version

* Update doc/source/conf.py

Co-authored-by: Marc Garcia <[email protected]>

---------

Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Marc Garcia <[email protected]>
@code-narrator code-narrator mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista left review comments

Assignees
No one assigned
Labels
CI Continuous Integration Web pandas website
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

CI/BLD: Doc builds are failing CI: pydata sphinx theme 0.11 broke doc build
4 participants
@mroeschke @datapythonista @rhshadrach @jorisvandenbossche