-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
use is_integer in df.insert #53194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
topper-123
merged 7 commits into
pandas-dev:main
from
auderson:fix_insert_isinstance_int
May 14, 2023
Merged
use is_integer in df.insert #53194
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f3d5b1c
use is_integer
auderson cf6fe68
add test
auderson 7c6c3a6
reformat file
auderson c2f80a4
Merge branch 'main' into fix_insert_isinstance_int
auderson 0f3a45e
convert non stdlib ints to satisfy typing checks
auderson 52657b6
add GH number
auderson 6449f27
add to whatsnew
auderson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,3 +110,8 @@ def test_insert_frame(self): | |
) | ||
with pytest.raises(ValueError, match=msg): | ||
df.insert(1, "newcol", df) | ||
|
||
def test_insert_int64_loc(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add the |
||
df = DataFrame({"a": [1, 2]}) | ||
df.insert(np.int64(0), "b", 0) | ||
tm.assert_frame_equal(df, DataFrame({"b": [0, 0], "a": [1, 2]})) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you convert non stdlib ints to satisfy typing checks?