use is_integer in df.insert #53194
Merged
use is_integer in df.insert #53194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 12, 2023
| @@ -4800,7 +4800,7 @@ def insert( | |||
| if not allow_duplicates and column in self.columns: | |||
| # Should this be a different kind of error?? | |||
| raise ValueError(f"cannot insert {column}, already exists") | |||
| if not isinstance(loc, int): | |||
| if not is_integer(loc): | |||
There was a problem hiding this comment.
Could you convert non stdlib ints to satisfy typing checks?
mroeschke
reviewed
May 12, 2023
| @@ -110,3 +110,8 @@ def test_insert_frame(self): | |||
| ) | |||
| with pytest.raises(ValueError, match=msg): | |||
| df.insert(1, "newcol", df) | |||
|
|
|||
| def test_insert_int64_loc(self): | |||
There was a problem hiding this comment.
Could you add the GH issue number?
mroeschke
reviewed
May 12, 2023
|
Which section of the whatsnew note should I add it to, Conversion? |
Sure |
|
done
|
|
Thanks, @auderson. |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.