CLN/depr: dt.to_pydatetime #52803
Merged
CLN/depr: dt.to_pydatetime #52803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 20, 2023
pandas/core/indexes/accessors.py
Outdated
| @@ -328,19 +334,19 @@ def to_pydatetime(self) -> np.ndarray: | |||
| 1 2018-03-11 | |||
| dtype: datetime64[ns] | |||
|
|
|||
| >>> s.dt.to_pydatetime() | |||
| >>> s.dt.to_pydatetime() # doctest: +SKIP | |||
There was a problem hiding this comment.
I think I would prefer to keep these examples running, so that when we change the behavior we are reminded to change these examples
There was a problem hiding this comment.
Ok, I can see that point. Keep the deprecation notice?
There was a problem hiding this comment.
Keep the deprecation notice?
Yes definitely
phofl
approved these changes
Apr 22, 2023
|
thx @topper-123 |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup related to #52459. The example code causes warning when running
ci/code_checks.sh, this suppresses that.