DEPR: to_pydatetime return Index[object] #52459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Deprecate
mroeschke
reviewed
Apr 6, 2023
mroeschke
reviewed
Apr 7, 2023
pandas/io/sql.py
Outdated
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings("ignore") | ||
| # GH#52459 to_pydatetime will return Index[object] | ||
| d = ser.dt.to_pydatetime() |
There was a problem hiding this comment.
Probably good to call np.asarray on d ahead of the deprecation enforcement since data_list is typed list[np.ndarray]
mroeschke
reviewed
Apr 8, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Apr 8, 2023
|
Thanks @jbrockmendel |
This was referenced Apr 20, 2023
|
Should this have been done for |
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.