Skip to content

Typing: Narrow down types of argument keep for nsmallest and nlargest #52753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2023
+3 −1
Merged

Typing: Narrow down types of argument keep for nsmallest and nlargest #52753

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a20293
Typing: Narrow down types of argument keep for nsmallest and nlargest
mattkeanny Apr 18, 2023
5635f3d
fixed formatting with black
mattkeanny Apr 20, 2023
0ceac49
Merge branch 'pandas-dev:main' into typingKeep
mattkeanny Apr 20, 2023
1a465e0
Merge branch 'main' into typingKeep
mattkeanny Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3897,7 +3897,7 @@ def nlargest(
"""
return selectn.SelectNSeries(self, n=n, keep=keep).nlargest()

def nsmallest(self, n: int = 5, keep: str = "first") -> Series:
def nsmallest(self, n: int = 5, keep: Literal["first", "last", "all"] = "first") -> Series:
"""
Return the smallest `n` elements.

Expand Down