Skip to content

Typing: Narrow down types of argument keep for nsmallest and nlargest #52753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2023
Merged

Typing: Narrow down types of argument keep for nsmallest and nlargest #52753

merged 4 commits into from
Apr 20, 2023

Conversation

mattkeanny
Copy link
Contributor

  • Typing: Narrow down types of arguments (Series) for nsmallest and nlargest
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
@noatamir
Copy link
Member

Thanks for the PR @mattkeanny! The CI caught some errors which I think you can solve locally if you run pre-commit. Let us know if you need help.

twoertwein
twoertwein approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you need to run black to format that line.

@twoertwein twoertwein merged commit 75435a7 into pandas-dev:main Apr 20, 2023
@twoertwein
Copy link
Member

Thanks @mattkeanny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkeanny @noatamir @twoertwein