Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC Trying to improve Group by split-apply-combine guide #51916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Trying to improve Group by split-apply-combine guide #51916
Changes from 2 commits
586a520
dea035c
4763d8f
ea29699
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something incorrect with leaving "one" out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the options are either:
"An operation that is split into multiple steps using built-in GroupBy operations, will be more efficient than one using the apply method with a user-defined Python function."
Or:
"Splitting into multiple steps using built-in GroupBy operations, will be more efficient than using the apply method with a user-defined Python function."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice the comma added here - I believe that is incorrect. These are not independent clauses.
In your second option above, I believe you're missing a noun: "Splitting an operation into multiple groups...". I see no reason to prefer one version over the other and because of that I think this should be left as is - but let me know if you think there is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed this can be phrased better, but I believe the change here is incorrect - it states that a nuisance column must contain numerical values. Any object column is consider a nuisance column. I'd suggest "Any object column, even if it contains..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note in general is out of date -
numeric_only
now defaults to False and so they will no longer be automatically excluded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change to your suggestion and remove the out of date note.