Skip to content

DOC Trying to improve Group by split-apply-combine guide #51916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2023

Conversation

DeaMariaLeon
Copy link
Member

@DeaMariaLeon DeaMariaLeon commented Mar 12, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Group by - split-apply-combine.pdf

My aim was to make it easier for the reader. I removed some grammar errors, and tried to cut the lenght of very long sentences.

Also:

  • Ln: 46 The word "apply" doesn't make sense to me. I think that it's an error - but I need a reviewer to confirm please.
  • Ln: 78 Removed "pandas objects can be split on any of their axes" - I think this needs to be removed because group_by axis=1 was deprecated. But again, it needs to be checked.
  • Ln: 102 Same, I thought "axis labels" was not correct because of my previous comment.
  • Ln: 272 I'm not sure what you mean. Is "tab" supposed to work on vscode? or on ipython?
  • Ln: 364 Trying to cut the long sentence.

I wrote that I was going to do this on PR #51704.

Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English is not my native language, so I' a bit unsure of some of the phrases, maybe someone with better english skills can review. I've commented on some of the technical changes.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - lots of good changes here. Some questions / requests.

@pandas-dev pandas-dev deleted a comment from github-actions bot Mar 18, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 2.0 milestone Mar 18, 2023
@DeaMariaLeon
Copy link
Member Author

Thanks a lot @rhshadrach and @topper-123 for reviewing this PR

@rhshadrach
Copy link
Member

/preview

@github-actions
Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/51916/

@rhshadrach rhshadrach merged commit c73c1c8 into pandas-dev:main Mar 18, 2023
@rhshadrach
Copy link
Member

Thanks @DeaMariaLeon!

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 18, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c73c1c8cc34fded44e4262596f0f82631628e8b1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #51916: DOC Trying to improve Group by split-apply-combine guide'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-51916-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #51916 on branch 2.0.x (DOC Trying to improve Group by split-apply-combine guide)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@rhshadrach
Copy link
Member

When I tagged this as 2.0, I was thinking it'd be fine to ship with the 2.0 release since it's just docs in the user guide. However, looking at the conflicts, I now realize that part of this update includes the axis=1 deprecation which will only be in 2.1. So I think we should not backport this.

I've removed the tag, but pinging people to make sure this doesn't mess anything else up. cc @datapythonista @simonjayhawkins

@DeaMariaLeon DeaMariaLeon deleted the groupby branch March 18, 2023 15:27
@datapythonista
Copy link
Member

Thanks for the ping. Sounds good to me, since no backport PR has been created/merged I think the original milestone shouldn't affect anything, all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants