-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC Trying to improve Group by split-apply-combine guide #51916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English is not my native language, so I' a bit unsure of some of the phrases, maybe someone with better english skills can review. I've commented on some of the technical changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR - lots of good changes here. Some questions / requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks a lot @rhshadrach and @topper-123 for reviewing this PR |
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/51916/ |
Thanks @DeaMariaLeon! |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
When I tagged this as 2.0, I was thinking it'd be fine to ship with the 2.0 release since it's just docs in the user guide. However, looking at the conflicts, I now realize that part of this update includes the I've removed the tag, but pinging people to make sure this doesn't mess anything else up. cc @datapythonista @simonjayhawkins |
Thanks for the ping. Sounds good to me, since no backport PR has been created/merged I think the original milestone shouldn't affect anything, all good. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Group by - split-apply-combine.pdf
My aim was to make it easier for the reader. I removed some grammar errors, and tried to cut the lenght of very long sentences.
Also:
I wrote that I was going to do this on PR #51704.