Skip to content

DEPR: added deprecation warning for NDFrame.bool #51756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 2, 2023
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
abab690
added deprecation warning
ramvikrams Mar 3, 2023
79981ec
Added test and corrected the warning
ramvikrams Mar 3, 2023
ed09b05
Update generic.py
ramvikrams Mar 3, 2023
9972bc6
Update generic.py
ramvikrams Mar 3, 2023
a0dd906
Update test_generic.py
ramvikrams Mar 3, 2023
b0c69d6
removed examples from doc
ramvikrams Mar 4, 2023
e5ccfa4
Update test_generic.py
ramvikrams Mar 4, 2023
4f8814a
Merge branch 'pandas-dev:main' into t03
ramvikrams Mar 10, 2023
748a8e0
added warning in 'ignored_doctest_warnings'
ramvikrams Mar 10, 2023
13cf306
updated path
ramvikrams Mar 10, 2023
70d26ac
updated other tests with bool
ramvikrams Mar 10, 2023
c6bd26f
Update conftest.py
ramvikrams Mar 10, 2023
bcb5bb9
Update test_series.py
ramvikrams Mar 10, 2023
dd2b1e1
required changes done
ramvikrams Mar 14, 2023
ea3fee4
minimal changes
ramvikrams Mar 14, 2023
a84aa47
Update generic.py
ramvikrams Mar 14, 2023
9808540
Update generic.py
ramvikrams Mar 14, 2023
a15a723
Update conftest.py
ramvikrams Mar 14, 2023
ad7c16d
updated the warning
ramvikrams Mar 14, 2023
11fe948
warning message changed
ramvikrams Mar 14, 2023
559520c
Update test_series.py
ramvikrams Mar 14, 2023
9622449
update
ramvikrams Mar 14, 2023
4908a89
Update conftest.py
ramvikrams Mar 14, 2023
f3256db
Update conftest.py
ramvikrams Mar 15, 2023
39f1f63
Merge branch 'main' into t03
ramvikrams Mar 15, 2023
0478351
Update conftest.py
ramvikrams Mar 15, 2023
81882aa
Update conftest.py
ramvikrams Mar 16, 2023
505c82b
Update conftest.py
ramvikrams Mar 16, 2023
2dbdb82
Merge branch 'pandas-dev:main' into t03
ramvikrams Mar 17, 2023
84ab13d
Update conftest.py
ramvikrams Mar 17, 2023
a8c90d5
added okwarning to docs build and whatsnew entry
ramvikrams Mar 23, 2023
73a0fb5
Merge branch 'main' into t03
ramvikrams Mar 23, 2023
baa2b12
merged branches
ramvikrams Mar 23, 2023
f62c490
Update v0.13.0.rst
ramvikrams Mar 23, 2023
b21328f
Update test_frame.py
ramvikrams Mar 23, 2023
712f0f6
Update test_frame.py
ramvikrams Mar 23, 2023
2168bfd
Done required changes
ramvikrams Mar 23, 2023
c3c2c30
Update test_generic.py
ramvikrams Mar 23, 2023
0473b4c
Merge branch 'main' into t03
ramvikrams Mar 23, 2023
5ef2373
Update v0.13.0.rst
ramvikrams Mar 31, 2023
9c518b5
Merge branch 'main' into t03
ramvikrams Mar 31, 2023
1a9b06e
Update v2.1.0.rst
ramvikrams Mar 31, 2023
014d685
Update v0.13.0.rst
ramvikrams Apr 1, 2023
ce4cefa
Merge branch 'main' into t03
ramvikrams Apr 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1504,6 +1504,14 @@ def bool(self) -> bool_t:
"bool cannot act on a non-boolean single element "
f"{type(self).__name__}"
)
else:
warnings.warn(
f"Passing a slice to {type(self).__name__}.take is deprecated "
"and will raise in a future version. Use `obj[slicer]` or pass "
"a sequence of integers instead.",
FutureWarning,
stacklevel=find_stack_level(),
)

self.__nonzero__()
# for mypy (__nonzero__ raises)
Expand Down