DEPR: added deprecation warning for NDFrame.bool #51756

ramvikrams · 2023-03-03T09:41:31Z

closes DEPR: NDFrame.bool #51749
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

pandas/core/generic.py

jbrockmendel · 2023-03-03T18:26:56Z

You'll need to update the docs to remove/suppress deprecated usages

ramvikrams · 2023-03-03T18:35:57Z

You'll need to update the docs to remove/suppress deprecated usages

Sorry, but I coudn't understand can please explain it again or are you talking about adding a whatsnew entry

rhshadrach · 2023-03-04T13:36:41Z

@ramvikrams - the method you are deprecating is used in our documentation. Building the docs now emits warnings; the documentation needs to be adjusted so that these warnings no longer appear:

https://github.com/pandas-dev/pandas/actions/runs/4323640786/jobs/7547478298#step:6:67

ramvikrams · 2023-03-04T14:20:00Z

@ramvikrams - the method you are deprecating is used in our documentation. Building the docs now emits warnings; the documentation needs to be adjusted so that these warnings no longer appear:

https://github.com/pandas-dev/pandas/actions/runs/4323640786/jobs/7547478298#step:6:67

I actually looked over the net and revious pr's but could not find out how to adjust the documentation , can you please sujjest a walkthrough or any pr that had the same issue

rhshadrach · 2023-03-04T14:25:06Z

can you please sujjest a walkthrough or any pr that had the same issue

#51395

ramvikrams · 2023-03-04T16:02:20Z

So should I remove the examples from docstring of bool and other bool instances in the doc

rhshadrach · 2023-03-09T22:19:26Z

So should I remove the examples from docstring of bool and other bool instances in the doc

I think you should leave the examples in. You can add them to the filtered warnings here:

pandas/pandas/conftest.py

Line 133 in 27f7365

ignored_doctest_warnings = [

ramvikrams · 2023-03-10T18:42:38Z

@rhshadrach actually now I did the required changes but still Doc Build and Upload fails could you please check

rhshadrach

This is looking good! Some requests below.

pandas/core/generic.py

pandas/tests/generic/test_frame.py

pandas/tests/generic/test_generic.py

pandas/tests/generic/test_series.py

pandas/tests/window/test_timeseries_window.py

doc/source/whatsnew/v0.13.0.rst

doc/source/whatsnew/v2.1.0.rst

pandas/core/generic.py

pandas/tests/generic/test_frame.py

pandas/tests/generic/test_generic.py

pandas/tests/generic/test_series.py

pandas/tests/window/test_timeseries_window.py

rhshadrach

Looking good!

doc/source/whatsnew/v0.13.0.rst

rhshadrach · 2023-03-31T20:00:26Z

/preview

github-actions · 2023-03-31T20:00:37Z

Website preview of this PR available at: https://pandas.pydata.org/preview/51756/

doc/source/whatsnew/v0.13.0.rst

rhshadrach

lgtm

ramvikrams · 2023-04-02T02:12:23Z

@rhshadrach is the PR mergeable now

rhshadrach · 2023-04-02T12:51:53Z

Thanks @ramvikrams!

ramvikrams · 2023-04-02T12:53:10Z

Thanks @ramvikrams!

thanks sir

added deprecation warning

abab690

ramvikrams changed the title ~~gh-51749 : added deprecation warning~~ gh-51749 : added deprecation warning for NDFrame.bool Mar 3, 2023

MarcoGorelli reviewed Mar 3, 2023

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

ramvikrams added 4 commits March 3, 2023 17:40

Added test and corrected the warning

79981ec

Update generic.py

ed09b05

Update generic.py

9972bc6

Update test_generic.py

a0dd906

rhshadrach changed the title ~~gh-51749 : added deprecation warning for NDFrame.bool~~ DEPR: added deprecation warning for NDFrame.bool Mar 4, 2023

rhshadrach added the Deprecate Functionality to remove in pandas label Mar 4, 2023

ramvikrams added 2 commits March 4, 2023 20:33

removed examples from doc

b0c69d6

Update test_generic.py

e5ccfa4

ramvikrams added 6 commits March 10, 2023 19:20

Merge branch 'pandas-dev:main' into t03

4f8814a

added warning in 'ignored_doctest_warnings'

748a8e0

updated path

13cf306

updated other tests with bool

70d26ac

Update conftest.py

c6bd26f

Update test_series.py

bcb5bb9

rhshadrach requested changes Mar 13, 2023

View reviewed changes

ramvikrams added 4 commits March 14, 2023 13:45

required changes done

dd2b1e1

minimal changes

ea3fee4

Update generic.py

a84aa47

Update generic.py

9808540

ramvikrams added 6 commits March 23, 2023 10:32

added okwarning to docs build and whatsnew entry

a8c90d5

Merge branch 'main' into t03

73a0fb5

merged branches

baa2b12

Update v0.13.0.rst

f62c490

Update test_frame.py

b21328f

Update test_frame.py

712f0f6

rhshadrach requested changes Mar 23, 2023

View reviewed changes

ramvikrams added 3 commits March 23, 2023 23:31

Done required changes

2168bfd

Update test_generic.py

c3c2c30

Merge branch 'main' into t03

0473b4c

rhshadrach requested changes Mar 31, 2023

View reviewed changes

doc/source/whatsnew/v0.13.0.rst Outdated Show resolved Hide resolved

ramvikrams added 3 commits March 31, 2023 12:00

Update v0.13.0.rst

5ef2373

Merge branch 'main' into t03

9c518b5

Update v2.1.0.rst

1a9b06e

rhshadrach requested changes Mar 31, 2023

View reviewed changes

doc/source/whatsnew/v0.13.0.rst Outdated Show resolved Hide resolved

doc/source/whatsnew/v0.13.0.rst Outdated Show resolved Hide resolved

ramvikrams added 2 commits April 1, 2023 08:14

Update v0.13.0.rst

014d685

Merge branch 'main' into t03

ce4cefa

rhshadrach approved these changes Apr 1, 2023

View reviewed changes

rhshadrach added this to the 2.1 milestone Apr 2, 2023

rhshadrach merged commit d54bd78 into pandas-dev:main Apr 2, 2023

ramvikrams deleted the t03 branch April 2, 2023 12:53

rhshadrach mentioned this pull request Apr 2, 2023

DEPR: List of deprecations to be removed in 3.0 #50578

Open

topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 6, 2023

DEPR: NDFrame.bool (pandas-dev#51756)

d0bf95c

topper-123 mentioned this pull request Apr 20, 2023

CLN/depr: NDFrame.bool #52802

Merged

mroeschke mentioned this pull request Feb 8, 2024

CLN: Remove .bool(), __init__, __float__ from DataFrame/Series #57308

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPR: added deprecation warning for NDFrame.bool #51756

DEPR: added deprecation warning for NDFrame.bool #51756

ramvikrams commented Mar 3, 2023 •

edited

Loading

jbrockmendel commented Mar 3, 2023

ramvikrams commented Mar 3, 2023 •

edited

Loading

rhshadrach commented Mar 4, 2023

ramvikrams commented Mar 4, 2023

rhshadrach commented Mar 4, 2023

ramvikrams commented Mar 4, 2023

rhshadrach commented Mar 9, 2023

ramvikrams commented Mar 10, 2023

rhshadrach left a comment

rhshadrach left a comment

rhshadrach commented Mar 31, 2023

github-actions bot commented Mar 31, 2023

rhshadrach left a comment

ramvikrams commented Apr 2, 2023

rhshadrach commented Apr 2, 2023

ramvikrams commented Apr 2, 2023

DEPR: added deprecation warning for NDFrame.bool #51756

DEPR: added deprecation warning for NDFrame.bool #51756

Conversation

ramvikrams commented Mar 3, 2023 • edited Loading

jbrockmendel commented Mar 3, 2023

ramvikrams commented Mar 3, 2023 • edited Loading

rhshadrach commented Mar 4, 2023

ramvikrams commented Mar 4, 2023

rhshadrach commented Mar 4, 2023

ramvikrams commented Mar 4, 2023

rhshadrach commented Mar 9, 2023

ramvikrams commented Mar 10, 2023

rhshadrach left a comment

Choose a reason for hiding this comment

rhshadrach left a comment

Choose a reason for hiding this comment

rhshadrach commented Mar 31, 2023

github-actions bot commented Mar 31, 2023

rhshadrach left a comment

Choose a reason for hiding this comment

ramvikrams commented Apr 2, 2023

rhshadrach commented Apr 2, 2023

ramvikrams commented Apr 2, 2023

ramvikrams commented Mar 3, 2023 •

edited

Loading

ramvikrams commented Mar 3, 2023 •

edited

Loading