Skip to content

STYLE enable ruff TCH on pandas/core/arrays #51754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

STYLE enable ruff TCH on pandas/core/arrays #51754

wants to merge 8 commits into from

Conversation

t0uch9r455
Copy link

@t0uch9r455 t0uch9r455 commented Mar 3, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@t0uch9r455
Copy link
Author

I finished the task STYLE enable ruff TCH #51740

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Mar 3, 2023

thanks @clarkwiththew - can you remove the folder for which you've enabled this (pandas/core/arrays) from pyproject.toml please?

@MarcoGorelli MarcoGorelli changed the title Added changes for type checking STYLE enable ruff TCH on pandas/core/arrays Mar 3, 2023
@t0uch9r455
Copy link
Author

I removed the folder from pyproject.toml

@MarcoGorelli
Copy link
Member

thanks - can you also run pre-commit run --all-files please?

@MarcoGorelli
Copy link
Member

something went wrong when merging, there's lots of unrelated changes

@t0uch9r455
Copy link
Author

I'm fixing it right now

@t0uch9r455
Copy link
Author

I've made some changes, hopefully the issues should be removed

@MarcoGorelli
Copy link
Member

not quite, sorry

@t0uch9r455 t0uch9r455 closed this by deleting the head repository Mar 4, 2023
@t0uch9r455
Copy link
Author

t0uch9r455 commented Mar 4, 2023

I think the pre-commit changed a lot of other files, I'm going to try again on a new branch

@t0uch9r455
Copy link
Author

I ran the pre-commit and only the edited files should be changed now. I made a new PR here:

#51786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants