-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STYLE enable ruff TCH #51740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am working on pandas/core/arrays |
Doing pandas/core/io/* |
I am working on
|
Continue to working on
|
I did "pandas/_libs/*" |
I will try |
Trying pandas/core/resample.py |
I'll go for |
Working on
|
Working on:
|
Working on, and @MarcoGorelli , maybe need to reopen this issue again, when #51827 merged.
|
Working on : |
I am working on "pandas/util/*" = ["TCH"] |
hey @Ramyahkay are you working on "pandas/core/nanops.py" = ["TCH"] ?? |
Yes, I am still working on it. |
@ahmad2901 (or anyone else) - feel free to submit a PR and close off this issue, at this point I presume they're no longer working on it |
Sure I will do it. |
This code actually may make a difference to performance:
Task here is:
0. make sure you've followed the steps in https://pandas.pydata.org/docs/dev/development/contributing.html and have set up your development environment
pandas/pyproject.toml
Lines 293 to 326 in d385465
pre-commit run ruff --all-files
, and fix up the issues it reports. You can see STYLE start enabling TCH #51687 for some examples of how to do thispre-commit run ruff --all-files
passes, then stage, commit, push, open pull request, celebratePlease don't comment "take" on this issue (as multiple people can be assigned), and don't ask for permission to work on it. Instead, just leave a comment letting people know which
The text was updated successfully, but these errors were encountered: