Skip to content

BUG: Weighted rolling aggregations min_periods=0 #51611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2023
Merged

BUG: Weighted rolling aggregations min_periods=0 #51611

merged 3 commits into from
Mar 4, 2023

Conversation

Savlik
Copy link
Contributor

@Savlik Savlik commented Feb 24, 2023 •
edited
Loading

@simonjayhawkins simonjayhawkins added Bug Window rolling, ewma, expanding labels Feb 24, 2023
mroeschke
mroeschke reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Could you add a whatsnew note in v2.1.0.rst?

@Savlik
Copy link
Contributor Author

Savlik commented Feb 26, 2023

Looks pretty good. Could you add a whatsnew note in v2.1.0.rst?

Sure thing. Done.

@mroeschke
Copy link
Member

Looks like there's a merge conflict. Can you merge main once more?

@mroeschke mroeschke added this to the 2.1 milestone Mar 4, 2023
@mroeschke mroeschke merged commit ff187c0 into pandas-dev:main Mar 4, 2023
@mroeschke
Copy link
Member

Thanks @Savlik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Window rolling, ewma, expanding
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: Weighted rolling aggregations do not respect min_periods=0
4 participants
@Savlik @mroeschke @simonjayhawkins @tomas-pavlik-SF