Skip to content

TST/bug: add test for NaT in Categorical.isin with empty string #51587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2023
Merged

TST/bug: add test for NaT in Categorical.isin with empty string #51587

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1737821
TST: add test for NaT in Categorical with empty string
topper-123 Feb 23, 2023
5530d0d
remove whatsnew entry
topper-123 Feb 23, 2023
46c3878
Merge branch 'main' into categorical_isin_NaT
topper-123 Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/tests/arrays/categorical/test_algos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ def test_isin_cats():
tm.assert_numpy_array_equal(expected, result)


@pytest.mark.parametrize("value", [[""], [None, ""], [pd.NaT, ""]])
def test_isin_cats_corner_cases(value):
# GH36550
cat = pd.Categorical([""])
result = cat.isin(value)
expected = np.array([True], dtype=bool)
tm.assert_numpy_array_equal(expected, result)


@pytest.mark.parametrize("empty", [[], pd.Series(dtype=object), np.array([])])
def test_isin_empty(empty):
s = pd.Categorical(["a", "b"])
Expand Down