TST/bug: add test for NaT in Categorical.isin with empty string

[topper-123]

• closes BUG: Categorical series .isin({pd.NaT, ...}) gives all-False #36550
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This bug was present in pandas v1.5, but is not present in v2.0.rc1. I added a test for this working as expected now.

[simonjayhawkins]

This bug was present in pandas v1.5, but is not present in v2.0.rc1. I added a test for this working as expected now.

Thanks. Looking at the date of the issue, the bug was present before 1.5.

Things may have changed since I took a break, but we don't normally add a release note when we just add a regression test.

Any idea which PR fixed the issue?

[phofl]

No whatsnew note, this is still correct

[topper-123]

Any idea which PR fixed the issue?

No, I just tried the code snippet in the issue and saw that the problem is gone. Then I tried it in v1.5, where it was still present :-).

In v1.5 I also got a warning, when I ran the snippet (FutureWarning: Inferring timedelta64[ns] from data containing strings is deprecated and will be removed in a future version. To retain the old behavior explicitly pass Series(data, dtype=timedelta64[ns])), so my guess is whatever fixed that warning, also fixed this, but that's just a guess.

I could do a bisect, but IMO that's probably not worth it...

[simonjayhawkins]

I could do a bisect, but IMO that's probably not worth it...

no problem. The reason I asked is that the PR that fixed may have had a release note and the issue number could have been appended instead of adding the release note here.

[topper-123]

Yeah, I looked through the whatsnew to find canditates and found several candidates and figured it wasn't worth it to figure which one it was...

I've removed the whatsnew entry in the newest commit.

[mroeschke]

Thanks @topper-123