Skip to content

CI: Fix failure due to warning #51573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023
Merged

CI: Fix failure due to warning #51573

merged 2 commits into from
Feb 23, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 23, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @mroeschke any idea why this wasn't failing before?

https://app.circleci.com/pipelines/github/pandas-dev/pandas/25348/workflows/8a8ef371-75fe-4c4e-b928-33e74b63f1f9/jobs/59312

@mroeschke
Copy link
Member

Huh that's odd. Yeah not sure why this wasn't caught.

Should be rectified in #51545 (comment) I think (there is an unnecessary pyarrow version check here since our min pyarrow version is 7 now)

@simonjayhawkins simonjayhawkins added the CI Continuous Integration label Feb 23, 2023
@phofl
Copy link
Member Author

phofl commented Feb 23, 2023

I'll merge this, checked 5 builds only failures from the other pr. Then we should get a green ci again there

@phofl phofl added this to the 2.0 milestone Feb 23, 2023
@phofl phofl merged commit fb80674 into pandas-dev:main Feb 23, 2023
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 23, 2023
phofl added a commit that referenced this pull request Feb 23, 2023
…51586)

Backport PR #51573: CI: Fix failure due to warning

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the ci_failure branch February 23, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants