Skip to content

TST/CLN: Remove unnecessary pyarrow version checking #51545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 23, 2023
Merged

TST/CLN: Remove unnecessary pyarrow version checking #51545

merged 9 commits into from
Feb 23, 2023

Conversation

mroeschke
Copy link
Member

I think this shouldn't be necessary since 7.0 is the minimum version supported now.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Feb 21, 2023
jbrockmendel
jbrockmendel reviewed Feb 22, 2023
View reviewed changes
pandas/core/arrays/arrow/array.py Outdated
# https://issues.apache.org/jira/browse/ARROW-12042
fallback_performancewarning("7")
if null_placement is None:
fallback_performancewarning()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the warning still necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think now this can raise an error directly

jbrockmendel
jbrockmendel approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@jbrockmendel
Copy link
Member

FAILED pandas/tests/indexes/test_common.py::test_sort_values_invalid_na_position[string-pyarrow-None] - AssertionError: Did not see expected warning of class 'PerformanceWarning'
FAILED pandas/tests/indexes/test_common.py::test_sort_values_invalid_na_position[string-pyarrow-middle] - AssertionError: Did not see expected warning of class 'PerformanceWarning'

@mroeschke mroeschke mentioned this pull request Feb 23, 2023
Merged
5 tasks
@mroeschke
Copy link
Member Author

Looks like the (some?) failures are due to #51483 (should have been more careful with merging after being stricter with the warnings)

@phofl
Copy link
Member

phofl commented Feb 23, 2023

Can you remove my tm.assert_produces_warning when you are ready here?

@mroeschke mroeschke added this to the 2.0 milestone Feb 23, 2023
@mroeschke
Copy link
Member Author

Can you remove my tm.assert_produces_warning when you are ready here?

Sure, done in the last commit.

Going to merge and backport just in case 2.0 has any PRs that impact test_arrow.py

@mroeschke mroeschke merged commit 8baedc1 into pandas-dev:main Feb 23, 2023
@mroeschke mroeschke deleted the tst/cln/unneeded_pa_checking branch February 23, 2023 18:53
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 23, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 23, 2023
@mroeschke @meeseeksmachine
Backport PR pandas-dev#51545: TST/CLN: Remove unnecessary pyarrow ver…
75775d8 
…sion checking
mroeschke added a commit that referenced this pull request Feb 23, 2023
@meeseeksmachine @mroeschke
Backport PR #51545 on branch 2.0.x (TST/CLN: Remove unnecessary pyarr…
b178966 
…ow version checking) (#51595)

Backport PR #51545: TST/CLN: Remove unnecessary pyarrow version checking

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jbrockmendel @phofl